From b1dd179f856c426ed91bd42f5859e2c874682595 Mon Sep 17 00:00:00 2001 From: Alex <40072887+alexdcrane@users.noreply.github.com> Date: Thu, 31 Jul 2025 16:18:33 -0700 Subject: [PATCH] Dashboard - Minor bug fixes (#7440) * Dashboard - Minor bug fixes * Update config.php * Update config.php * Fix label background color * Update dashboard_edit.php * Update parent.php * Update index.php * Update index.php --- .../resources/dashboard/config.php | 6 +- .../resources/dashboard/config.php | 2 +- .../resources/dashboard/config.php | 2 +- core/dashboard/dashboard_edit.php | 106 +++++++++--------- core/dashboard/index.php | 54 +++++---- core/dashboard/resources/dashboard/icon.php | 6 +- core/dashboard/resources/dashboard/parent.php | 26 ++--- 7 files changed, 100 insertions(+), 102 deletions(-) diff --git a/app/call_forward/resources/dashboard/config.php b/app/call_forward/resources/dashboard/config.php index edc3f0c0a..fac0499b9 100644 --- a/app/call_forward/resources/dashboard/config.php +++ b/app/call_forward/resources/dashboard/config.php @@ -13,7 +13,7 @@ $array['dashboard'][$x]['dashboard_height'] = ''; $array['dashboard'][$x]['dashboard_content'] = ''; $array['dashboard'][$x]['dashboard_content_text_align'] = ''; $array['dashboard'][$x]['dashboard_content_details'] = ''; -$array['dashboard'][$x]['dashboard_chart_type'] = ''; +$array['dashboard'][$x]['dashboard_chart_type'] = 'doughnut'; $array['dashboard'][$x]['dashboard_label_enabled'] = 'true'; $array['dashboard'][$x]['dashboard_label_text_color'] = ''; $array['dashboard'][$x]['dashboard_label_text_color_hover'] = ''; @@ -22,7 +22,7 @@ $array['dashboard'][$x]['dashboard_label_background_color_hover'] = ''; $array['dashboard'][$x]['dashboard_number_text_color'] = ''; $array['dashboard'][$x]['dashboard_number_text_color_hover'] = ''; $array['dashboard'][$x]['dashboard_number_background_color'] = ''; -$array['dashboard'][$x]['dashboard_background_color'] =''; +$array['dashboard'][$x]['dashboard_background_color'] = ''; $array['dashboard'][$x]['dashboard_background_color_hover'] = ''; $array['dashboard'][$x]['dashboard_detail_background_color'] = ''; $array['dashboard'][$x]['dashboard_column_span'] = '1'; @@ -66,7 +66,7 @@ $array['dashboard'][$x]['dashboard_label_background_color_hover'] = ''; $array['dashboard'][$x]['dashboard_number_background_color'] = ''; $array['dashboard'][$x]['dashboard_number_text_color'] = '#0292ff'; $array['dashboard'][$x]['dashboard_number_text_color_hover'] = ''; -$array['dashboard'][$x]['dashboard_background_color'] =''; +$array['dashboard'][$x]['dashboard_background_color'] = ''; $array['dashboard'][$x]['dashboard_background_color_hover'] = ''; $array['dashboard'][$x]['dashboard_detail_background_color'] = ''; $array['dashboard'][$x]['dashboard_column_span'] = '1'; diff --git a/app/domain_limits/resources/dashboard/config.php b/app/domain_limits/resources/dashboard/config.php index 1da94e627..790f8764f 100644 --- a/app/domain_limits/resources/dashboard/config.php +++ b/app/domain_limits/resources/dashboard/config.php @@ -26,7 +26,7 @@ $array['dashboard'][$x]['dashboard_background_color_hover'] = ''; $array['dashboard'][$x]['dashboard_detail_background_color'] = '#ffffff'; $array['dashboard'][$x]['dashboard_column_span'] = '1'; $array['dashboard'][$x]['dashboard_row_span'] = '2'; -$array['dashboard'][$x]['dashboard_details_state'] = 'expanded'; +$array['dashboard'][$x]['dashboard_details_state'] = 'hidden'; $array['dashboard'][$x]['dashboard_order'] = '120'; $array['dashboard'][$x]['dashboard_enabled'] = 'false'; $array['dashboard'][$x]['dashboard_description'] = ''; diff --git a/app/ring_groups/resources/dashboard/config.php b/app/ring_groups/resources/dashboard/config.php index 1c658f56e..b176cfe07 100644 --- a/app/ring_groups/resources/dashboard/config.php +++ b/app/ring_groups/resources/dashboard/config.php @@ -13,7 +13,7 @@ $array['dashboard'][$x]['dashboard_height'] = ''; $array['dashboard'][$x]['dashboard_content'] = ''; $array['dashboard'][$x]['dashboard_content_text_align'] = ''; $array['dashboard'][$x]['dashboard_content_details'] = ''; -$array['dashboard'][$x]['dashboard_chart_type'] = ''; +$array['dashboard'][$x]['dashboard_chart_type'] = 'doughnut'; $array['dashboard'][$x]['dashboard_label_enabled'] = 'true'; $array['dashboard'][$x]['dashboard_label_text_color'] = '#444444'; $array['dashboard'][$x]['dashboard_label_text_color_hover'] = ''; diff --git a/core/dashboard/dashboard_edit.php b/core/dashboard/dashboard_edit.php index 822196e9c..62084418a 100644 --- a/core/dashboard/dashboard_edit.php +++ b/core/dashboard/dashboard_edit.php @@ -828,10 +828,8 @@ echo "\n"; echo " \n"; - if ($c < sizeof($dashboard_detail_background_color) - 1) { echo "
\n"; } - } - //swap button - if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color) && sizeof($dashboard_detail_background_color) > 1) { - echo " \n"; - echo button::create(['type'=>'button','title'=>$text['button-swap'],'icon'=>'fa-solid fa-arrow-right-arrow-left fa-rotate-90','style'=>"z-index: 0; position: absolute; display: inline-block; margin: -14px 0 0 7px;",'onclick'=>"document.getElementById('dashboard_detail_background_color_temp').value = document.getElementById('dashboard_detail_background_color_0').value; document.getElementById('dashboard_detail_background_color_0').value = document.getElementById('dashboard_detail_background_color_1').value; document.getElementById('dashboard_detail_background_color_1').value = document.getElementById('dashboard_detail_background_color_temp').value; this.blur();"])."
\n"; - } - else { - echo "
\n"; - } + echo "\n"; + echo "\n"; + echo $text['label-dashboard_detail_background_color']."\n"; + echo "\n"; + echo "\n"; + if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color)) { + foreach ($dashboard_detail_background_color as $c => $detail_background_color) { + echo " \n"; + if ($c < sizeof($dashboard_detail_background_color) - 1) { echo "
\n"; } } - if (empty($dashboard_detail_background_color) || (is_array($dashboard_detail_background_color) && count($dashboard_detail_background_color) < 2)) { - echo " \n"; - if (empty($dashboard_detail_background_color)) { - echo " \n"; - } + //swap button + if (!empty($dashboard_detail_background_color) && is_array($dashboard_detail_background_color) && sizeof($dashboard_detail_background_color) > 1) { + echo " \n"; + echo button::create(['type'=>'button','title'=>$text['button-swap'],'icon'=>'fa-solid fa-arrow-right-arrow-left fa-rotate-90','style'=>"z-index: 0; position: absolute; display: inline-block; margin: -14px 0 0 7px;",'onclick'=>"document.getElementById('dashboard_detail_background_color_temp').value = document.getElementById('dashboard_detail_background_color_0').value; document.getElementById('dashboard_detail_background_color_0').value = document.getElementById('dashboard_detail_background_color_1').value; document.getElementById('dashboard_detail_background_color_1').value = document.getElementById('dashboard_detail_background_color_temp').value; this.blur();"])."
\n"; } - if (!empty($dashboard_detail_background_color) && !is_array($dashboard_detail_background_color)) { - echo "
\n"; - echo "
\n"; + else { + echo "
\n"; } - echo $text['description-dashboard_detail_background_color']."\n"; - echo "\n"; - echo "\n"; } + if (empty($dashboard_detail_background_color) || (is_array($dashboard_detail_background_color) && count($dashboard_detail_background_color) < 2)) { + echo " \n"; + if (empty($dashboard_detail_background_color)) { + echo " \n"; + } + } + if (!empty($dashboard_detail_background_color) && !is_array($dashboard_detail_background_color)) { + echo "
\n"; + echo "
\n"; + } + echo $text['description-dashboard_detail_background_color']."\n"; + echo "\n"; + echo "\n"; echo "\n"; echo "\n"; @@ -1096,7 +1092,7 @@ echo "\n"; echo " \n"; $i=1; - while ($i <= 3) { + while ($i <= 4) { $selected = ($i == $dashboard_row_span) ? "selected" : null; echo " \n"; $i++; @@ -1125,23 +1121,21 @@ echo "\n"; echo "\n"; - if ($dashboard_details_state != "none") { - echo "\n"; - echo "\n"; - echo " ".$text['label-dashboard_details_state']."\n"; - echo "\n"; - echo "\n"; - echo " \n"; - echo "
\n"; - echo $text['description-dashboard_details_state']."\n"; - echo "\n"; - echo "\n"; - } + echo "\n"; + echo "\n"; + echo " ".$text['label-dashboard_details_state']."\n"; + echo "\n"; + echo "\n"; + echo " \n"; + echo "
\n"; + echo $text['description-dashboard_details_state']."\n"; + echo "\n"; + echo "\n"; if (permission_exists('dashboard_parent_uuid')) { echo " "; diff --git a/core/dashboard/index.php b/core/dashboard/index.php index ebc0c1f48..2c257a000 100644 --- a/core/dashboard/index.php +++ b/core/dashboard/index.php @@ -1,4 +1,3 @@ -